- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1
 
Onboarding fixes #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding fixes #101
Conversation
4c8691c    to
    ad115c5      
    Compare
  
    ae6f8cb    to
    f9e3dad      
    Compare
  
            
          
                cmd/root.go
              
                Outdated
          
        
      | accountCmd.GroupID = "account" | ||
| whoamiCmd.GroupID = "account" | ||
| 
               | 
          ||
| secretsCmd.GroupID = "workflow" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is debatable bc secrets is in its own module, cre secrets create. generate-binding doesnt belong to any module. same thing applies to login/logout and whoami.
@ejacquier let me know if this is how you want to group the commands. happy to adjust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved secrets to its own module
moved genbinding to others.
| Usage: | ||
| {{.CommandPath}} [command] | ||
| Available Commands: | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- can 
Available Commandsbe shown only if there are sub-commands. right now for commands like init, version, login and any sub-command like workflow/deploy if you do--help, it prints out emptyAvailable Commands:
Eg: 
❯ cre workflow deploy --help
Compiles the workflow, uploads the artifacts, and registers the workflow in the Workflow Registry contract.
Usage:
  cre workflow deploy [command]
Available Commands:
Flags:
  -r, --auto-start           Activate and run the workflow after registration, or pause it
                             (default true)
  -h, --help                 help for deploy
  -o, --output string        The output file for the compiled WASM binary encoded in base64
                             (default "./binary.wasm.br.b64")
  -l, --owner-label string   Label for the workflow owner (used during auto-link if owner is
                             not already linked)
      --unsigned             If set, the command will either return the raw transaction
                             instead of sending it to the network or execute the second step
                             of secrets operations using a previously generated raw transaction
      --yes                  If set, the command will skip the confirmation prompt and proceed
                             with the operation even if it is potentially destructive
Use "cre workflow deploy [command] --help" for more information about a command.
💡 Tip: New here? Run:
  cre init
  to create your first cre project.
📘 Need more help?
  Visit https://docs.chain.link/cre
- Also the 
ExamplesandGlobal Flagsare no longer shown now, while it was previously. It should be brought back? 
❯ cre workflow deploy --help
Compiles the workflow, uploads the artifacts, and registers the workflow in the Workflow Registry contract.
Usage:
  cre workflow deploy <workflow-folder-path> [flags]
Examples:
		cre workflow deploy ./my-workflow
Flags:
  -r, --auto-start           Activate and run the workflow after registration, or pause it (default true)
  -h, --help                 help for deploy
  -o, --output string        The output file for the compiled WASM binary encoded in base64 (default "./binary.wasm.br.b64")
  -l, --owner-label string   Label for the workflow owner (used during auto-link if owner is not already linked)
      --unsigned             If set, the command will either return the raw transaction instead of sending it to the network or execute the second step of secrets operations using a previously generated raw transaction
      --yes                  If set, the command will skip the confirmation prompt and proceed with the operation even if it is potentially destructive
Global Flags:
  -e, --env string            Path to .env file which contains sensitive info (default ".env")
  -R, --project-root string   Path to the project root
  -T, --target string         Set the target settings
  -v, --verbose               Print DEBUG logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @anirudhwarrier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. please see test plan for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
Uh oh!
There was an error while loading. Please reload this page.